[check_postgres] bug in txn_wraparound perfdata output

Cédric Villemain cedric.villemain at dalibo.com
Mon Mar 30 15:19:25 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Cédric Villemain a écrit :
> Greg Sabino Mullane a écrit :
>> Crappy UTF-8 problems with git commit notwithstanding, I've applied this patch.
>> I also cleaned up the whole sub while I was at it. Please test heavily, this was
>> done quickly and has no unit test yet. Thanks!
> 
> 
> 'my' patch is used on production servers, seems ok.(on a 2.7.3)
> I check the HEAD one...
> ...
> It looks ok (I did some --include --exclude checks and also with --output mrtg)


Ahem, I don't know exactly what was my process but I was wrong ... :-(

The following lines must be reversed :

 $db->{perf} .= " $dbname=$dbtxns";
 next SLURP if skip_item($dbname);

- --->

 next SLURP if skip_item($dbname);
 $db->{perf} .= " $dbname=$dbtxns";

> 
> 
> 
> I suggest to add the doc too (as for backend):
> 
>     Be careful when using filtering: an inclusion rule on the database name, for
>     example, may report no problems not only because the matching database
>     had no backends, but because you misspelled the name of the database!
> 
> 
> Perhaps a sticky note about filtering ...
> 
_______________________________________________
Check_postgres mailing list
Check_postgres at bucardo.org
https://mail.endcrypt.com/mailman/listinfo/check_postgres

- --
Cédric Villemain
Administrateur de Base de Données
Cel: +33 (0)6 74 15 56 53
http://dalibo.com - http://dalibo.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknQ4vkACgkQo/dppWjpEvwf4wCfXoEGpGGttqaTYXwPG9sIUInA
cdcAoICxDSuASDvZ7MOQzD1XZGTIvZFW
=CmVf
-----END PGP SIGNATURE-----


More information about the Check_postgres mailing list