[check_postgres] Patch for multi-slony status check

Jehan-Guillaume (ioguix) de Rorthais jgdr at dalibo.com
Mon Aug 16 08:28:35 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 11/08/2010 20:08, Greg Sabino Mullane a écrit :
>> It is based on search_path instead of explicit the schema to look 
>> for sl_status and sl_node in database.
> 
> Won't this break check_postgres for people who are currently 
> using the action? At the very least we need to aim for 
> backwards compatibility with the flag (i.e. "--schema").

Yeah, that's right.

I wanted to use search_path because, in my opinion, it makes more sense
considering this option goes in the connection options structure in run_command
function and is used to set the search_path session parameter.

I had 2 solutions: support both options or renaming back --search_path as --schema.

As the first solution leads to a spaghetti code, I preferred the second one.

PFA the new patch.

Regards,
- -- 
Jehan-Guillaume de Rorthais
DBA
http://www.dalibo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxo9qsACgkQXu9L1HbaT6JSNwCgwwDzkD98NO4N1t3UWcP4OGJE
kwIAoKzYirM7/jLKBtH0+AXvk6WVkPQH
=4rPi
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_multi-slony_v2.patch.gz
Type: application/x-gzip
Size: 2008 bytes
Desc: not available
Url : https://mail.endcrypt.com/pipermail/check_postgres/attachments/20100816/e02a499c/attachment.gz 


More information about the Check_postgres mailing list