[check_postgres] what to do with same_schema behaviour

[Guillaume Lelarge]

Le 16/12/2009 16:06, Cédric Villemain a écrit :
> Le mercredi 16 décembre 2009 15:48:07, Greg Sabino Mullane a écrit :
>>> attnum is defined so same_schema will never succes.
>>>
>>> So the issue is that schema are the same. I think that same_schema must
>>> not complain in this case.
>>>
>>> *But* same_schema should try to reorder by removing droppped column.
>>
>> Yes, I agree we should do this. Bucardo already does the same thing, so
>> it should be a simple matter of stealing the code from there.
>>
>> Perhaps you can make a bug for this?
>>
>> http://bucardo.org/bugzilla/enter_bug.cgi?product=check_postgres
>>
> 
> Ah ! tank you for providing the link again ;) 
> 
> Here the bug for our readers : 
> http://bucardo.org/bugzilla/show_bug.cgi?id=24
> 
> I probably won't be able to patch until next year  :/
> 

I took some free time to work on this. Patch attached. I checked it a
few times, and it seems to work well. I'm not a Perl coder, so take a
good look at it. There's probably a better way to do what I did.

BTW, the subdirectory "t" seems to be about unit testing. Is that so?
How can one launch all the checks?


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: droppedcolumns.patch
Type: text/x-patch
Size: 1802 bytes
Desc: not available
Url : https://mail.endcrypt.com/pipermail/check_postgres/attachments/20100127/5efd7dba/attachment.bin