[check_postgres] Patch to fix an issue with slony_status report when one uses a service to connect

[Guillaume Lelarge]

Le 02/03/2010 14:07, Greg Sabino Mullane a écrit :
>> Once again, it happens only when you use --dbservice option. When
>> someone use this option, $db->{dbname} is not initialized. (I said "Once
>> again" because we already had the issue with the vacuum/analyze report.
>> My patch is a modified copy of the one I sent for the vacuum/analyze
>> report issue.)
>>
>> The patch attached fixes it.
> 
> Thanks! I tweaked the regex a little bit and moved the database call to 
> after the three important numbers. Pushed to git if you want to test.
> 

I checked and it worked great. Thanks Greg.

> That "once again" sounds like we need to add a unit test to make sure 
> we don't have this keep happening...
> 

Hope you didn't take the "once again" in a bad way. It was just my way
to say I already wrote that kind of patch previously.

But, sure, a unit test would be a good thing.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com