[check_postgres] RFC: New Actions

[David E. Wheeler]

On Jan 20, 2011, at 7:48 AM, Greg Sabino Mullane wrote:

>> I think this is kind of neat, and could easily apply to the idle transaction stuff, too:
>> 
>>    --critical '15 seconds'        # same as now
>>    --critical 20                  # 20 or more idle transactions
>>    --critical '15 seconds && 20'  # 20 or more idle for 15s or longer
>>    --critical '15 seconds || 20'  # 20 or more idle or one or more idle 15s or longer.
>> 
>> Thoughts?
> 
> Very interesting. I'm slightly wary of using those metacharacters. One alternative 
> is to (also? only?) allow "English" equivalents:
> 
>  --critical '15 sec or 20 items'
>  --critical '20 txns and 30 seconds'

Done. See attached patch. I wrote a bunch of tests of the validation function, too. If this meets muster for you, I'll also update the idle transaction patch to do something similar.

Best,

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-and-and-or-for-percent-and-size-para.patch
Type: application/octet-stream
Size: 28849 bytes
Desc: not available
Url : https://mail.endcrypt.com/pipermail/check_postgres/attachments/20110120/65cae0e6/attachment-0001.obj