[check_postgres] some more checks

Cédric Villemain cedric.villemain.debian at gmail.com
Mon Nov 7 13:13:39 UTC 2011


Hello

2011/11/6 Greg Sabino Mullane <greg at endpoint.com>:
> On Fri, Nov 04, 2011 at 03:25:02PM +0100, Cédric Villemain wrote:
> ...
>> Before sending the patchs (I still have to write documentation), is
>> there some comments on the proposal ?
>
> Looks overall fine to me, but I'd like to see shorter names or at least
> aliases for some things. For example, can we say POSTGRES_CLUSTER_ID
> instead of POSTGRES_CLUSTER_IDENTIFIER? Use --assume-prod
> and --assume-standby as aliases for the longer versions?

I didn't change for standby, but apply the suggestion for production
and cluster_id.
I've created a pull request via github :
https://github.com/bucardo/check_postgres/pull/9



>
> --
> Greg Sabino Mullane greg at endpoint.com
> End Point Corporation
> PGP Key: 0x14964AC8
>



-- 
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-check-cluster_id.patch
Type: text/x-patch
Size: 8098 bytes
Desc: not available
Url : https://mail.endcrypt.com/pipermail/check_postgres/attachments/20111107/254251a9/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Reduce-code-duplicates-around-pg_controldata.patch
Type: text/x-patch
Size: 4243 bytes
Desc: not available
Url : https://mail.endcrypt.com/pipermail/check_postgres/attachments/20111107/254251a9/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-an-assume-prod-option.patch
Type: text/x-patch
Size: 6467 bytes
Desc: not available
Url : https://mail.endcrypt.com/pipermail/check_postgres/attachments/20111107/254251a9/attachment-0002.bin 


More information about the Check_postgres mailing list