[check_postgres] [PATCH] Add `pgagent_jobs` test.
David E. Wheeler
david.wheeler at pgexperts.com
Thu Jan 19 22:02:41 UTC 2012
On Jan 19, 2012, at 1:58 PM, Cédric Villemain wrote:
> emit critical if > 2 hours (or < 0)
> It breaks at least "query_runtime" and "last*analyze|vacuum" checks
> for time range . but is ok for others time range check, I didn't check
> others checks.
>
> For me it is an improvement: better nagios integration, easier
> documentation for check_postgres (less confusion on what -w -c mean in
> this or this check).
>
> I won't argue very strongly to break backward compatibility.
> We can decide that some checks are not clean and we accept the old
> syntax for them (but not your new one :p).
Yeah, that’s what I was thinking: If there is no :, fall back on the old parser.
> How to handle change in !clean checks is probably going to make it in
> its own thread.
Given that it might take some effort, I think I might like to push my change now, and then refactor for your changes when they’re done (dropping any_warning at that time). Thoughts?
David
More information about the Check_postgres
mailing list