[check_postgres] Time for a release?

[Glyn Astill]

> From: Christoph Berg <christoph.berg at credativ.de>

> To: Glyn Astill <glynastill at yahoo.co.uk>
> Cc: check_postgres <check_postgres at bucardo.org>
> Sent: Tuesday, 23 June 2015, 16:06
> Subject: Re: [check_postgres] Time for a release?
> 
> Re: To Glyn Astill 2015-06-23 <20150623121143.GD10284 at msg.credativ.de>
>>  > >Can we make a release soonish?
>>  > 
>>  > I know it takes time for someone to work through them, but there's 
> also quite a lot of pull requests that are valid fixes for issues.  
>> 
>>  True, but not releasing because of that isn't a very appealing option
>>  either... :-/
> 
> IMHO the release could happen now so we have something to base on.
> 
>>  > Currently I've been cherry picking the ones I need into my own 
> fork, but it would be nice to see them committed.
>> 
>>  I'll have a look (I know I said that before... :)
> 
> Glyn, which PRs would you like to see merged first? #91? others?
> 
> 


Yes it would be good to get all the changes that are showing in #91 - those are the ones that suit me currently.  I'd not actually intended to add HEAD of my fork as that pull request, sorry, but I guess it groups all the changes I'd like.

Currently those changes cause "make test" fail on 3 checks for same_schema on my system, which I think can only be my fault. E.g.

#   Failed test 'Action 'same_schema' reports sequence differences'
#   at t/02_same_schema.t line 343.
#                   'POSTGRES_SAME_SCHEMA CRITICAL: DB "postgres" (hosts:/tmp/cptesting_socket,/tmp/cptesting_socket2) Databases were different. Items not matched: 1 | time=0.56s 
# DB 1: dbservice= port=5432 host=/tmp/cptesting_socket dbname=postgres user=check_postgres_testing 
# DB 1: PG version: 9.4.4
# DB 1: Total objects: 16
# DB 2: dbservice= port=5432 host=/tmp/cptesting_socket2 dbname=postgres user=check_postgres_testing 
# DB 2: PG version: 9.4.4
# DB 2: Total objects: 16
# Sequence "wakko.yakko":
#  "increment_by" is different:
#     Database 1: 1
#     Database 2: 3
#  "max_value" is different:
#     Database 1: 9223372036854775807
#     Database 2: 100
#  "min_value" is different:
#     Database 1: 1
#     Database 2: 10
#  "start_value" is different:
#     Database 1: 1
#     Database 2: 10
# 
# '
#     doesn't match '(?^s:^POSTGRES_SAME_SCHEMA CRITICAL.*Items not matched: 1 .*
# \s*Sequence "wakko.yakko":
# \s*"increment_by" is different:
# \s*Database 1: 1
# \s*Database 2: 3
# \s*"last_value" is different:
# \s*Database 1: 1
# \s*Database 2: 10
# \s*"max_value" is different:
# \s*Database 1: 9223372036854775807
# \s*Database 2: 100
# \s*"min_value" is different:
# \s*Database 1: 1
# \s*Database 2: 10
# \s*"start_value" is different:
# \s*Database 1: 1
# \s*Database 2: 10\s*$)'


Looking at the regex in the line "# doesn't match '(?^s:^POSTGRES_SAME_SCHEMA CRITICAL.*Items not matched: 1 .*" makes me think that it should match, but I'm also seeing messages like "sh: warning: setlocale: LC_ALL: cannot change locale (en)" - so I guess I'm missing a locale. Perhaps that's the issue?

I've attached my tests of HEAD and HEAD of my fork.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: glynastill_test_9.4.txt
URL: <https://mail.endcrypt.com/pipermail/check_postgres/attachments/20150623/1f40d2ea/attachment-0003.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: test_9.4.txt
URL: <https://mail.endcrypt.com/pipermail/check_postgres/attachments/20150623/1f40d2ea/attachment-0004.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: test_9.0.txt
URL: <https://mail.endcrypt.com/pipermail/check_postgres/attachments/20150623/1f40d2ea/attachment-0005.txt>