[check_postgres] check_sequence broken in HEAD

[Glyn Astill]

----- Original Message -----
> From: Christoph Berg <christoph.berg at credativ.de>
> To: Glyn Astill <glynastill at yahoo.co.uk>
> Cc: "check_postgres at bucardo.org" <check_postgres at bucardo.org>
> Sent: Wednesday, 15 April 2015, 16:50
> Subject: Re: [check_postgres] check_sequence broken in HEAD
>>
>>  https://github.com/bucardo/check_postgres/pull/90
> 
> 
> Hi,
> 
> thanks for spotting.
> 
> I've pushed your commits after rebasing the branch to remove some
> no-op commits.
> 


Cheers, apologies about the no-ops; I made quite a hash of syncing up my repo.

I'm also seeing some issues with the newer fancy version check_same_schema comparing a lot of oid and attnum based columns, as well as it not taking into account that trigger names are not unique unless  their schema & table name is also taken into account.  


Is this a work in progress or expected?  Looking at the script I think most of the oid column issues can be fixed by excluding them and adding in pg_get_* definition functions, but I'm not sure what's needed to fix the trigger name issue as it looks like that's used as the key for the hash and in various lookups.

Glyn