[check_postgres] check_sequence broken in HEAD

Christoph Berg christoph.berg at credativ.de
Wed Apr 15 20:24:13 UTC 2015


Re: Glyn Astill 2015-04-15 <2134242480.4340165.1429117023283.JavaMail.yahoo at mail.yahoo.com>
> Cheers, apologies about the no-ops; I made quite a hash of syncing up my repo.
> 
> I'm also seeing some issues with the newer fancy version check_same_schema comparing a lot of oid and attnum based columns, as well as it not taking into account that trigger names are not unique unless  their schema & table name is also taken into account.  

I've had regression test problems with the checkpoint and cluster_id
checks but these seemed unrelated to your and my fixes. What problem
are you seeing?

> Is this a work in progress or expected?  Looking at the script I think most of the oid column issues can be fixed by excluding them and adding in pg_get_* definition functions, but I'm not sure what's needed to fix the trigger name issue as it looks like that's used as the key for the hash and in various lookups.

Christoph
-- 
cb at df7cb.de | http://www.df7cb.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://mail.endcrypt.com/pipermail/check_postgres/attachments/20150415/43a248b4/attachment.sig>


More information about the Check_postgres mailing list